Refactor ID handling and decouple Network Instance assignment#5381
Refactor ID handling and decouple Network Instance assignment#5381priyaranjannanda wants to merge 2 commits intoopenconfig:mainfrom
Conversation
priyaranjannanda
commented
Apr 24, 2026
priyaranjannanda
commented
- Ensuring that the InterfaceRefInterfaceIDFormat deviation only affects the naming of the interface (e.g., adding the .0 sub-interface suffix)
…nt from naming deviations.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how interface IDs are handled within the test suite to improve clarity and maintainability. By decoupling the network instance assignment from specific interface naming deviations, the code becomes more robust and easier to manage across different device configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5381 / 4f46aa3Virtual Devices
Hardware Devices
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the handling of the InterfaceRefInterfaceIDFormat deviation within the ISIS configuration and metric change functions to ensure consistent interface naming. It also simplifies the logic in the configureDUT function. A minor style issue was identified where a space is missing before an opening brace in an if statement, which violates the Go style guide.
…_test/aggregate_all_not_forwarding_viable_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
